Tk/dynamic crashlytics #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TadeasKriz Hello! Can we have a pre-release (alpha01 or something) so we can help with testing? I have a large dynamic framework which might trigger other side effects |
|
Hello @TadeasKriz thanks for this fix! Do you know if there is a timeline on when we could expect this to be merged and fixed? |
|
Sorry all. Review was on me and I've been super busy. Diving in... |
|
Thanks once again for this fix @TadeasKriz Just like @tamimattafi said, if you need real projects to test a pre-release, I can try to make some time to help with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've replaced direct usage of Firebase Crashlytics ObjC classes with dynamic calls. This way stripped symbols are no longer a problem. The one symbol we still need to mark as "unresolved" (
_FIRCLSExceptionRecordNSException) is available even after symbols are stripped. That means dyld is able to link it in runtime.I've also made it into a weak symbol to improve the error message when we try to use it, but it's not available.